Change in vdsm[master]: Multiple Gateways[1/2]: add sourceRouting module

danken at redhat.com danken at redhat.com
Mon Jun 24 12:04:40 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Multiple Gateways[1/2]: add sourceRouting module
......................................................................


Patch Set 19: (2 inline comments)

....................................................
File vdsm/sourceRoute.py
Line 136:             rules = self._getRules(network)
Line 137:             if rules:
Line 138:                 table = self._getTable(rules)
Line 139:                 if table:
Line 140:                     self.rules = rules
Why should remove() have such a side effect on "self"?
Line 141:                     self.routes = self._getRoutes(table)
Line 142:                     self.configurator.removeSourceRoute(self.routes,
Line 143:                                                         self.rules,
Line 144:                                                         self.device)


Line 161:     configure_parser.add_argument('gateway', help='IP address of the gateway')
Line 162:     configure_parser.add_argument('device', help='Device to use for routing')
Line 163: 
Line 164:     remove_parser = subparsers.add_parser('remove')
Line 165:     remove_parser.add_argument('bootproto', choices=('static', 'dhcp'),
I think that "none" is the preferred string these days.
Line 166:                                help='whether the IP information was acquired '
Line 167:                                'statically or via DHCP')
Line 168:     remove_parser.add_argument('device', help='Device for which to unset the '
Line 169:                                'routing')


-- 
To view, visit http://gerrit.ovirt.org/15207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list