Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...
barumuga at redhat.com
barumuga at redhat.com
Mon Jun 24 05:58:32 UTC 2013
Bala.FA has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell script
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File lib/vdsm/tool/libvirt_configure.py
Line 77: 3. libvirtd
Line 78: 4. qemu-sanlock.conf
Line 79: For using default files, don't pass parameters.
Line 80: """
Line 81: raise RuntimeError(usageMsg)
This case, userMsg won't be written to stdout. Is it expected?
Line 82:
Line 83: sys.stdout.write(usageMsg)
Line 84:
Line 85:
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 38: qconf="$2"
Line 39:
Line 40: ssl=`"$GETCONFITEM" "$VDSM_CONF_FILE" vars ssl true | tr A-Z a-z`
Line 41: if [ "$ssl" = '' ]; then
Line 42: echo 'FAILED: Could not read configuration' 1>&2
Is it good idea to change the text something like
'FAILED: Could not read configuration: ssl'
Line 43: return 3
Line 44: fi
Line 45:
Line 46: if [ "$ssl" = "true" ]; then
--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list