Change in vdsm[master]: Bugfix update device hooks: after_update_device failure.

danken at redhat.com danken at redhat.com
Sat Jun 22 04:53:56 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Bugfix update device hooks: after_update_device failure.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 2992:                 self.log.debug("Nic has been updated:\n %s" % vnicXML)
Line 2993:                 hooks.after_update_device(vnicXML, self.conf)
Line 2994:             except Exception as e:
Line 2995:                 vnicXML = vnicXMLBackup.toprettyxml(encoding='utf-8')
Line 2996:                 self.log.debug('Request failed: %s', vnicXML, exc_info=True)
I'm not sure about this change. I'd expect to log the exact XML that caused the failure, not the historical XML. Could you describe why your suggested semantics makes note sense?
Line 2997:                 hooks.after_update_device_fail(vnicXML, self.conf)
Line 2998:                 raise SetLinkAndNetworkError(e.message)
Line 2999:             yield
Line 3000:         except Exception:


-- 
To view, visit http://gerrit.ovirt.org/15982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab64f88e697e48ad2a3552d1361742846871ed8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list