Change in vdsm[master]: clientIF: Check disk alignment using virt-alignment-scan

fsimonce at redhat.com fsimonce at redhat.com
Fri Jun 21 16:11:07 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: clientIF: Check disk alignment using virt-alignment-scan
......................................................................


Patch Set 12: (2 inline comments)

....................................................
File client/vdsClient.py
Line 468:             driveSpecs['imageID'] = args[3]
Line 469:             driveSpecs['volumeID'] = args[4]
Line 470:         else:
Line 471:             driveSpecs['GUID'] = args[1]
Line 472:         alignment = self.s.getDiskAlignment(driveSpecs, vmId)
The parameters are inverted.
Line 473:         for pName, aligned in alignment.items():
Line 474:             print "\t%s = %s" % (pName, aligned)
Line 475:         sys.exit(0)
Line 476: 


....................................................
File vdsm/BindingXMLRPC.py
Line 361:     def vmDiskReplicateFinish(self, vmId, srcDisk, dstDisk):
Line 362:         vm = API.VM(vmId)
Line 363:         return vm.diskReplicateFinish(srcDisk, dstDisk)
Line 364: 
Line 365:     def diskGetAlignment(self, driveSpecs, vmId=None):
The parameters are inverted.
Line 366:         api = API.VM(vmId)
Line 367:         return api.getDiskAlignment(driveSpecs)
Line 368: 
Line 369:     def addNetwork(self, bridge, vlan=None, bond=None, nics=None, options={}):


-- 
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list