Change in vdsm[master]: Bugfix update device hooks: after_update_device failure.

gvallare at redhat.com gvallare at redhat.com
Fri Jun 21 15:19:20 UTC 2013


Giuseppe Vallarelli has uploaded a new change for review.

Change subject: Bugfix update device hooks: after_update_device failure.
......................................................................

Bugfix update device hooks: after_update_device failure.

In case of failure during before update device, after_update_device
should use the backup object, having vnicXML not in a valid state.

Change-Id: I0ab64f88e697e48ad2a3552d1361742846871ed8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=893576#c11
Signed-off-by: Giuseppe Vallarelli <gvallare at redhat.com>
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/15982/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index e8118a3..45bd046 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2992,6 +2992,7 @@
                 self.log.debug("Nic has been updated:\n %s" % vnicXML)
                 hooks.after_update_device(vnicXML, self.conf)
             except Exception as e:
+                vnicXML = vnicXMLBackup.toprettyxml(encoding='utf-8')
                 self.log.debug('Request failed: %s', vnicXML, exc_info=True)
                 hooks.after_update_device_fail(vnicXML, self.conf)
                 raise SetLinkAndNetworkError(e.message)


-- 
To view, visit http://gerrit.ovirt.org/15982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ab64f88e697e48ad2a3552d1361742846871ed8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>


More information about the vdsm-patches mailing list