Change in vdsm[master]: iproute2 binary wrapper

danken at redhat.com danken at redhat.com
Wed Jun 19 13:44:40 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: iproute2 binary wrapper
......................................................................


Patch Set 18: (2 inline comments)

....................................................
File tests/ipwrapperTests.py
Line 25: 
Line 26: 
Line 27: class TestIpwrapper(TestCaseBase):
Line 28:     def testRouteFromText(self):
Line 29:         _getRouteAttrs = lambda x: (x.network, x.ipaddr, x.device, x.table)
I do not have a deep preference to either way. Testing

 self.assertEqual(Route.fromtext(text), Route(attributes))

is a bit more aesthetic imho.
Line 30:         good_routes = {
Line 31:             'default via 192.168.99.254 dev eth0':
Line 32:             ('0.0.0.0/0', '192.168.99.254', 'eth0', None),
Line 33:             'default via 192.168.99.254 dev eth0 table foo':


Line 27: class TestIpwrapper(TestCaseBase):
Line 28:     def testRouteFromText(self):
Line 29:         _getRouteAttrs = lambda x: (x.network, x.ipaddr, x.device, x.table)
Line 30:         good_routes = {
Line 31:             'default via 192.168.99.254 dev eth0':
Yes, Rule and Route should not enforce their current limited implementation.
Line 32:             ('0.0.0.0/0', '192.168.99.254', 'eth0', None),
Line 33:             'default via 192.168.99.254 dev eth0 table foo':
Line 34:             ('0.0.0.0/0', '192.168.99.254', 'eth0', 'foo'),
Line 35:             '200.100.50.0/16 via 11.11.11.11 dev eth2 table foo':


-- 
To view, visit http://gerrit.ovirt.org/15335
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list