Change in vdsm[master]: Fix the charset conversion logic in hooks.py

danken at redhat.com danken at redhat.com
Wed Jun 19 08:02:58 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Fix the charset conversion logic in hooks.py
......................................................................


Patch Set 2: (1 inline comment)

....................................................
Commit Message
Line 7: Fix the charset conversion logic in hooks.py
Line 8: 
Line 9: The proper way to convert text from byte oriented string to unicode
Line 10: is to call str.decode(encoding). This patch fixes this and makes
Line 11: Jenkins tests work for people with diacritics in their names.
Thanks! This is easily reproducible with

 HELLO=今日は ./run_tests_local.sh hooksTests.py 

could you add such an env variable to the unit test?
Line 12: 
Line 13: Change-Id: I9063291f8a4a392b2913220fe2839386dcffd825


-- 
To view, visit http://gerrit.ovirt.org/15856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9063291f8a4a392b2913220fe2839386dcffd825
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>


More information about the vdsm-patches mailing list