Change in vdsm[master]: functional test: boot VM with network interface device

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Jun 19 00:08:52 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: functional test: boot VM with network interface device
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 172:     @skipNoKVM
Line 173:     def testStartSmallVM(self):
Line 174:         pciAddress = {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000',
Line 175:                       'function': '0x0', 'type': 'pci'}
Line 176:         interfaceDev = {'nicModel': 'virtio', 'macAddr': '52:54:00:59:F5:3F',
Thanks Giuseppe, this value can be anything that looks like a real MAC address. It's better to be different from any existing MAC addresses. If there were any conflicts, it is still OK, because the VM just lives for 60 seconds and the chance to have conflicts is very small.
Line 177:                         'network': '', 'address': pciAddress,
Line 178:                         'device': 'bridge', 'type': 'interface',
Line 179:                         'linkActive': True, 'filter': 'no-mac-spoofing'}
Line 180:         customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',


-- 
To view, visit http://gerrit.ovirt.org/15633
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c350074ce2b9712c468899075e5e2e22ee2550
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list