Change in vdsm[master]: [WIP] Feature hidden bond: Adding support for hiding bonds.

asegurap at redhat.com asegurap at redhat.com
Tue Jun 18 09:54:57 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: [WIP] Feature hidden bond: Adding support for hiding bonds.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File lib/vdsm/netinfo.py
Line 66:         if not os.path.exists(os.path.join(b, 'device')):
Line 67:             if _match_nic_name(nic, fake_nics):
Line 68:                 res.append(nic)
Line 69:         # De Morgan's law "not (A or B)"
Line 70:         # is the same as "(not A) and (not B)"
I don't think it is necessary to enunciate De Morgan's law. It is well known enough, I'd say.
Line 71:         elif not (_match_nic_name(nic, hidden_nics) or
Line 72:                   slaveOfBonds(nic, hidden_bonds)):
Line 73:             res.append(nic)
Line 74: 


Line 76: 
Line 77: 
Line 78: def slaveOfBonds(nic, hidden_bonds):
Line 79:     for bond in hidden_bonds:
Line 80:         if slaves(bond):
for bond in hidden_bonds:
    if nic in slaves(bond):
        return True
return False.

Otherwise you're just checking that the bond has slaves.
Line 81:             return True
Line 82:     return False
Line 83: 
Line 84: 


-- 
To view, visit http://gerrit.ovirt.org/15825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c734e27f674b47644b2c3c14861d7ee53670a7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list