Change in vdsm[master]: vm: add the live diskSizeExtend method

fsimonce at redhat.com fsimonce at redhat.com
Mon Jun 17 15:04:22 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vm: add the live diskSizeExtend method
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 3779: 
Line 3780:         drive = self._findDriveByUUIDs(driveSpecs)
Line 3781: 
Line 3782:         try:
Line 3783:             diskFormat = "qcow2" if drive.format == "cow" else "raw"
The entire flow here (lines 3783-3798) is correct only for cow. For raw we should refresh the volume (relevant for lvm) and use getVolumeInfo to feed the new size to blockResize.

Also the currentSize check would be impossible (for raw). We need a way to collect the current disk size seen by qemu (surprisingly this is not possible).
Line 3784:             # Apparently this is what libvirt would do anyway, except that
Line 3785:             # it would fail on NFS when root_squash is enabled, see BZ#963881
Line 3786:             currentSize = qemuImg.info(drive.path, diskFormat)['virtualsize']
Line 3787: 


-- 
To view, visit http://gerrit.ovirt.org/15614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list