Change in vdsm[master]: Remove Image.deleteRecover().

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Jun 16 05:47:50 UTC 2013


Eduardo has uploaded a new change for review.

Change subject: Remove Image.deleteRecover().
......................................................................

Remove Image.deleteRecover().

Since the image is renamed immediatly, this recover will fail
anyway.

Related to: BZ#960952, BZ#910013, BZ#905938, BZ#875708, BZ#864073

Change-Id: I73506488210e53abb2e416b10b2bfe0f091f7ec8
Signed-off-by: Eduardo <ewarszaw at redhat.com>
---
M vdsm/storage/image.py
1 file changed, 0 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/15747/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 5f39c91..182f1ab 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -137,12 +137,6 @@
         """
         Delete whole image
         """
-        name = "delete image %s retry" % imgUUID
-        vars.task.pushRecovery(task.Recovery(name, "image", "Image",
-                               "deleteRecover", [self.repoPath, sdUUID,
-                                                 imgUUID, str(postZero),
-                                                 str(force)]))
-
         try:
             self._delete(sdUUID, imgUUID, postZero, force)
         except se.StorageException:
@@ -151,15 +145,6 @@
         except Exception as e:
             self.log.error("Unexpected error", exc_info=True)
             raise se.ImageDeleteError("%s: %s" % (imgUUID, str(e)))
-
-    @classmethod
-    def deleteRecover(cls, taskObj, repoPath, sdUUID, imgUUID, postZero,
-                      force):
-        """
-        Delete image rollforward
-        """
-        Image(repoPath)._delete(sdUUID, imgUUID, misc.parseBool(postZero),
-                                misc.parseBool(force))
 
     def validateDelete(self, sdUUID, imgUUID):
         """


-- 
To view, visit http://gerrit.ovirt.org/15747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73506488210e53abb2e416b10b2bfe0f091f7ec8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>


More information about the vdsm-patches mailing list