Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

fsimonce at redhat.com fsimonce at redhat.com
Thu Jun 13 15:12:59 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: clientIF: Check image alignment using virt-alignment-scan
......................................................................


Patch Set 11:

1. the verb is an HSM vm-related verb where Image has no meaning: hotplugDisk, diskReplicateStart, etc. After all you're passing a diskSpecs not a PDIV.

2. it's not only about the name but it's about the signature, which should be (vmId, driveSpecs) and not (driveSpecs)

3. are you working with selinux enabled? I got a selinux error when I tried the patch, I didn't investigate much, anyway you could try to check if it can be fixed with sebool or if we need a bz

-- 
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list