Change in vdsm[master]: Separate libvirt network configuration from ifcfg

danken at redhat.com danken at redhat.com
Wed Jun 12 20:24:52 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Separate libvirt network configuration from ifcfg
......................................................................


Patch Set 9: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/netconf/Makefile.am
Line 23: 
Line 24: dist_vdsmnetconf_PYTHON = \
Line 25: 	__init__.py \
Line 26: 	ifcfg.py \
Line 27: 	libvirtCfg.py
* time to add the $(NULL) trick.

* how about starting to use the all-lowcaps convention of pep8?


-- 
To view, visit http://gerrit.ovirt.org/15178
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I798cca309f54c3497b18d83de4ff378f0bb6582b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list