Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal

danken at redhat.com danken at redhat.com
Wed Jun 12 13:55:33 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 5: CommitDate: 2013-06-04 22:15:54 +0800
Line 6: 
Line 7: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Line 8: 
Line 9: Since the ifcfg based network configuration conflicts with
Sorry, I do not understand the new conflict with Network Manager. If we are not using the interface, why shouldn't NM play with it?
Line 10: NetworkManager, we still need preserve configuration
Line 11: 'NM_CONTROLLED=no' on removing nic.
Line 12: 
Line 13: Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de


-- 
To view, visit http://gerrit.ovirt.org/15148
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list