Change in vdsm[master]: Simplify setNewMtu()

danken at redhat.com danken at redhat.com
Wed Jun 12 08:28:39 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Simplify setNewMtu()
......................................................................


Patch Set 10: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File lib/vdsm/netinfo.py
Line 517:                 elif netdict['iface'].startswith(iface + '.'):
Line 518:                     yield (network, netdict['iface'].split('.', 1)[1])
Line 519: 
Line 520:     def getVlansForIface(self, iface):
Line 521:         for vlanDevName in self.getVlanDevsForIface(iface):
This keeps confusing me. How does it fit with your "I believe that this belongs to the next patch. Must have been a mistake when splitting the change into different patches." ?
Line 522:             yield vlanDevName.split('.', 1)[1]
Line 523: 
Line 524:     def getVlanDevsForIface(self, iface):
Line 525:         for v, vdict in self.vlans.iteritems():


-- 
To view, visit http://gerrit.ovirt.org/15355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e8e0d45b7887af8fd1b003fd4c358826b77289
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list