Change in vdsm[master]: NetReload: netmodels for delNetwork

asegurap at redhat.com asegurap at redhat.com
Mon Jun 10 23:44:22 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: NetReload: netmodels for delNetwork
......................................................................


Patch Set 14: Fails

(1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 178:             self.configWriter.removeMasterBridge(iface.name)
Line 179:         to_be_removed = _netinfo.ifaceUsers(iface.name)
Line 180:         yield not to_be_removed
Line 181: 
Line 182:         if to_be_removed or not iface.destroyOnMasterRemoval:
I broke this :-( Obvious AttributeError from accessing destroyOnMasterRemoval on Nics.
Line 183:             ifup(iface.name)
Line 184: 
Line 185:     def removeBond(self, bonding):
Line 186:         with self.removeIface(bonding) as to_be_removed:


-- 
To view, visit http://gerrit.ovirt.org/14873
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list