Change in vdsm[master]: fix testBuildCmdLine not to be Fedora specific.

danken at redhat.com danken at redhat.com
Mon Jun 10 12:47:22 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: fix testBuildCmdLine not to be Fedora specific.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

This is *so* my own fault. Still, I am not happy with this fix.

....................................................
File tests/libvirtvmTests.py
Line 41:     'smp': '1', 'cpuPinning': {},
Line 42:     'vmchannel': 'true', 'qgaEnable': 'true',
Line 43:     'tabletEnable': False,
Line 44:     'displayNetwork': 'mydisp',
Line 45:     'manufacturer': constants.SMBIOS_MANUFACTURER,
"manufacturer" and "product" are NOT parameters that are acceptable by vmCreate. Thus, I very much resent their appearence in this dictionary.

Instead, the relevat vars (constants.SMBIOS_OSNAME, constants.SMBIOS_MANUFACTURER) should be monkey-patched.
Line 46:     'product': constants.SMBIOS_OSNAME,
Line 47:     'custom': {}},
Line 48: 
Line 49:     """<?xml version="1.0" encoding="utf-8"?>


-- 
To view, visit http://gerrit.ovirt.org/15507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2fff6d0de0c97b83f800a9264753f4478b6094
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>


More information about the vdsm-patches mailing list