Change in vdsm[master]: vm: check disk alignment using virt-alignment-scan

danken at redhat.com danken at redhat.com
Mon Jun 10 10:30:20 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vm: check disk alignment using virt-alignment-scan
......................................................................


Patch Set 10: I would prefer that you didn't submit this

I'm a bit confused by this PatchSet 10. It changes more than I've expected. For one's, do we really need/want to expose virtAlignScan in vdsm-python? Is the module rename needed now? How is this related to the BLANK_UUID generalization (which iicr Eduardo wanted long ago)?

-- 
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list