Change in vdsm[master]: iproute2 binary wrapper

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Sun Jun 9 15:30:09 UTC 2013


Mark Wu has posted comments on this change.

Change subject: iproute2 binary wrapper
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File vdsm/ipwrapper.py
Line 180: 
Line 181:     return output
Line 182: 
Line 183: 
Line 184: def ipRoute():
is ipRouteList() better?
Line 185:     command = [ipBinary, "route"]
Line 186:     return _execCmd(command)
Line 187: 
Line 188: 


-- 
To view, visit http://gerrit.ovirt.org/15335
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list