Change in vdsm[master]: vdsmd.init.in: break to pieces

Alon Bar-Lev alonbl at redhat.com
Sat Jun 8 06:59:33 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsmd.init.in: break to pieces
......................................................................


Patch Set 5:

Well, I think the split is really a cleanup, what important for supporting other distributions is the interaction between downstream and init script.

It could have been easier to review a patch that takes current init script and move it as-is to generic script with --background --pidfile= and command, create the sysv and systemd wrappers, and when interface is stabilized split that script into multiple scripts.

I can wait for the other patch, reviewing top-down.

--
To view, visit http://gerrit.ovirt.org/14826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c652704000c764c6e6f248605c6a3f4f3af5ace
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list