Change in vdsm[master]: netinfo: Simplify the check if an interface still has any ot...

danken at redhat.com danken at redhat.com
Fri Jun 7 06:58:34 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Simplify the check if an interface still has any other users.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File lib/vdsm/netinfo.py
Line 604:             if iface == vdict['iface']:
Line 605:                 users.add(v)
Line 606:         return users
Line 607: 
Line 608:     def ifaceHasOtherUsers(self, iface):
yes,  your patch can do equally well with  ifaceUsers(), and removing ifaceHasOtherUsers() altogether, it would be great.

ifaceHasOtherUsers was a very bad name to begin with. With your changes it becomes incomprehensible to me, so better drop the function if possible.
Line 609:         """
Line 610:         It's used to check if an interface has other direct users when one of
Line 611:         its user is removed. It could only happen in the following two cases:
Line 612: 


--
To view, visit http://gerrit.ovirt.org/15416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie70cbfcc4c561c98f2e90685329900796517f933
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list