Change in vdsm[master]: NetReload: netmodels for delNetwork

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jun 6 14:49:08 UTC 2013


Mark Wu has posted comments on this change.

Change subject: NetReload: netmodels for delNetwork
......................................................................


Patch Set 8: Verified

1. vlaned bridged network and bridgeless network
 
setup the following networks:
s.setupNetworks({'test1': {'vlan': '1', 'bonding': 'bond1', 'ipaddr': '192.168.122.6', 'netmask': '255.255.255.0', 'mtu': 1700}}, {'bond1':{'nics':['eth1', 'eth2']}},
                {'connectivityCheck':False})
s.setupNetworks({'test2': {'vlan': '2', 'bonding': 'bond1', 'ipaddr': '192.168.122.7', 'netmask': '255.255.255.0', 'mtu': 1600}}, {'bond1':{'nics':['eth1', 'eth2']}},
                {'connectivityCheck':False})
s.setupNetworks({'test6': { 'bonding': 'bond1', 'ipaddr': '192.168.122.13', 'netmask': '255.255.255.0', 'bridged': False}}, {},
                {'connectivityCheck':False})
s.setupNetworks({'test3': {'vlan': '2', 'nic': 'eth3', 'ipaddr': '192.168.122.11', 'netmask': '255.255.255.0', 'mtu': 1700}}, {},
                {'connectivityCheck':False})
s.setupNetworks({'test4': {'vlan': '3', 'nic': 'eth3', 'ipaddr': '192.168.122.10', 'netmask': '255.255.255.0', 'mtu': 1600}}, {},
                {'connectivityCheck':False})
s.setupNetworks({'test5': {'nic': 'eth3', 'ipaddr': '192.168.122.12', 'netmask': '255.255.255.0', 'bridged': False}}, {},
                {'connectivityCheck':False})

and then remove the networks one by one in different order. every network is removed properly.

During the test, I found that when the last vlaned bridge network is removed and only one bridgeless network user is remained, the mtu is not restored to default. This problem also exists in the master code, but it should not be a big problem.

2.  non-vlaned bridge network

s.setupNetworks({'test3': { 'nic': 'eth3', 'ipaddr': '192.168.122.11', 'netmask': '255.255.255.0', 'mtu': 1700}}, {},
s.setupNetworks({'test1': {'bonding': 'bond1', 'ipaddr': '192.168.122.6', 'netmask': '255.255.255.0', 'mtu': 1700}}, {'bond1':{'nics':['eth1', 'eth2']}},
                {'connectivityCheck':False})

removed successfully.

--
To view, visit http://gerrit.ovirt.org/14873
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list