Change in vdsm[master]: iproute2 binary wrapper

danken at redhat.com danken at redhat.com
Thu Jun 6 13:03:22 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: iproute2 binary wrapper
......................................................................


Patch Set 5: (2 inline comments)

(partial review)

(I do not recall the agreement regarding the module placement, but Toni has a point for keeping the module near its two users)

....................................................
File vdsm/ipwrapper.py
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: 
Line 20: from vdsm import utils
Line 21: import netaddr
import order: stdlib, site packages, and only then project-specifc
Line 22: from collections import defaultdict
Line 23: 
Line 24: 
Line 25: ipBinary = str(utils.CommandPath("ip", "/sbin/ip"))


Line 21: import netaddr
Line 22: from collections import defaultdict
Line 23: 
Line 24: 
Line 25: ipBinary = str(utils.CommandPath("ip", "/sbin/ip"))
use .cmd for consistency.
Line 26: 
Line 27: 
Line 28: def _isValid(ip, verifier):
Line 29:     try:


--
To view, visit http://gerrit.ovirt.org/15335
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list