Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks
agl at us.ibm.com
agl at us.ibm.com
Mon Jun 3 13:51:14 UTC 2013
Adam Litke has posted comments on this change.
Change subject: gluster: Added verbs for read, update, add and remove hooks
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 149: # Since: 4.10.3
Line 150: ##
Line 151: {'type': 'HookContent',
Line 152: 'data': {'content': 'str', 'type': 'str', 'md5sum': 'str'}}
Line 153:
Why isn't 'type' an enum?
Line 154: ##
Line 155: # @GlusterHook.read:
Line 156: #
Line 157: # Provides the hook content
Line 193: ##
Line 194: {'command': {'class': 'GlusterHook', 'name': 'update'},
Line 195: 'data': {'glusterCmd': 'str', 'hookLevel': 'HookLevel', 'hookName': 'str', 'hookData': 'str', 'hookMd5Sum': 'str'},
Line 196: 'returns': 'boolean'}
Line 197:
'bool' not 'boolean'
Line 198: ##
Line 199: # @GlusterHook.add:
Line 200: #
Line 201: # Add a hook file
--
To view, visit http://gerrit.ovirt.org/14145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list