Change in vdsm[master]: Split vdsm init script into pieces

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Mon Jun 3 09:29:46 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Split vdsm init script into pieces
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm_hooks/vdsmd_init/env_common.sh.in
Line 4: #
Line 5: # Licensed to you under the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 7: # (at your option) any later version.  See the files README and
Line 8: # LICENSE_GPL_v2 which accompany this distribution.
Yes.
Line 9: #
Line 10: 
Line 11: . @LIBEXECDIR@/ovirt_functions.sh
Line 12: 


....................................................
File vdsm/vdsmd.init.in
Line 49: 
Line 50:     echo $"Starting up vdsm daemon: "
Line 51:     local vdsm_nice=`$GETCONFITEM $CONF_FILE vars vdsm_nice -5`
Line 52: 
Line 53:     if type daemon >/dev/null 2>&1; then
This is because "daemon" is provided by /etc/init.d/functions and "start_daemon" is provided by /lib/lsb/init-functions . Debian and Ubuntu do not not provide /etc/init.d/functions but /lib/lsb/init-functions . As Alon suggests, we are going to implement different wrapper scripts for different distro, so I will use start_daemon for Debian family and daemon for Red Hat family, I will not use both in one script.
Line 54:         RUNDAEMON="daemon --user=vdsm"
Line 55:     elif type start_daemon >/dev/null 2>&1; then
Line 56:         RUNDAEMON="start_daemon -n $vdsm_nice -- /usr/bin/sudo -u vdsm"
Line 57:     else


--
To view, visit http://gerrit.ovirt.org/14826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c652704000c764c6e6f248605c6a3f4f3af5ace
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list