Change in vdsm[master]: getAllTasksList\Status with spUUID retrieves info only if ho...

ybronhei at redhat.com ybronhei at redhat.com
Mon Jun 3 08:24:08 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM
......................................................................


Patch Set 22: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 2105:     def getAllTasksStatuses(self):
Line 2106:         if self.lock.acquire(blocking=False):
Line 2107:             if self.spmRole == SPM_ACQUIRED:
Line 2108:                 try:
Line 2109:                     return self.taskMng.getAllTasksStatuses("spm")
got it.. I missed the securable thing before. thanks
Line 2110:                 finally:
Line 2111:                     self.lock.release()
Line 2112:             self.lock.release()
Line 2113:         raise se.SpmStatusError(self.spUUID)


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list