Change in vdsm[master]: NetReload: netmodels for addNetwork

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Jun 3 03:29:42 UTC 2013


Mark Wu has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................


Patch Set 16: (1 inline comment)

....................................................
File vdsm/netmodels.py
Line 140: 
Line 141: 
Line 142: class Bond(NetDevice):
Line 143:     def __init__(self, name, configurator, ipconfig=None, mtu=None, slaves=(),
Line 144:                  options='mode=802.3ad miimon=150'):
In objectivizeNetwork,  Bond.objectivize is called with the parameter 'bondingOptions' passed from engine, and then Bond.objectivize just pass it to Bond.__init__ if it's creating a new bond. The default options 'mode=802.3ad miimon=150' used hear will be overridden by 'None'. It's not what we expect. So probably we need change the default value of options to 'None' in the signature, and assign 'mode=802.3ad miimon=150' to it if None is passed in.
Line 145:         self.validateName(name)
Line 146:         self.slaves = slaves
Line 147:         if options:
Line 148:             self.validateOptions(name, options)


--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list