Change in vdsm[master]: tests: addNetwork/setupNetworks behaviour with invalid vlan ...

asegurap at redhat.com asegurap at redhat.com
Wed Jul 31 21:33:39 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: addNetwork/setupNetworks behaviour with invalid vlan names.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Would you mind moving it to unit testing?

....................................................
File tests/functional/networkTests.py
Line 227:         self.assertEqual(status, neterrors.ERR_BAD_PARAMS, msg)
Line 228: 
Line 229:     @RequireDummyMod
Line 230:     @ValidateRunningAsRoot
Line 231:     def testAddNetworkBadVlan(self):
I feel like this would be run more often and with less overhead as a unit test to configNetworks.
Line 232:         with dummyIf(1) as nics:
Line 233:             status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
Line 234:                                                    vlan=INVALID_VLANS[0],
Line 235:                                                    nics=nics)


Line 241:             self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg)
Line 242: 
Line 243:     @RequireDummyMod
Line 244:     @ValidateRunningAsRoot
Line 245:     def testSetupNetworksAddBadVlan(self):
I feel like this would be run more often and with less overhead as a unit test to configNetworks.
Line 246:         with dummyIf(1) as nics:
Line 247:             attrs = {'vlan': INVALID_VLANS[0], 'nic': nics[0]}
Line 248:             status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs},
Line 249:                                                       {}, {})


-- 
To view, visit http://gerrit.ovirt.org/17373
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd324a74fcf9c2f73887abf96a74638099f1df7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list