Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...

danken at redhat.com danken at redhat.com
Wed Jul 31 18:40:36 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
......................................................................


Removing update of 'node.startup' setting in 'addIscsiPortal'

I removed not working code in 'addIscsiPortal' method. It supposed
to update 'node.startup' setting to 'manual', but used 'discoverydb'
operational mode instead of 'node' what caused to exception.

Change-Id: Ib34952047367db196733e942416a232d12a4e491
Bug-Url: https://bugzilla.redhat.com/851050
Signed-off-by: Sergey Gotliv <sgotliv at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17212
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-by: Ayal Baron <abaron at redhat.com>
---
M vdsm/storage/iscsi.py
1 file changed, 0 insertions(+), 10 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Federico Simoncelli: Looks good to me, but someone else must approve
  Sergey Gotliv: Verified
  Dan Kenigsberg: Looks good to me, but someone else must approve

Objections:
  Eduardo: I would prefer that you didn't submit this


-- 
To view, visit http://gerrit.ovirt.org/17212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list