Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...

abaron at redhat.com abaron at redhat.com
Wed Jul 31 18:22:07 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
......................................................................


Patch Set 3: Looks good to me, approved

So we came round circle on this.
addIscsiPortal is only ever called from discoverSendTargets and is followed by try..finally and in the finally part deleteIscsiPortal is called, so indeed this code is redundant.

-- 
To view, visit http://gerrit.ovirt.org/17212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list