Change in vdsm[master]: Add hostusbdirect hook to vdsm_hooks.

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Jul 31 12:37:19 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: Add hostusbdirect hook to vdsm_hooks.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Looking at it, I have to say that I have to agree with Michal, it'd be better off to be integrated with the hostusb hook.

The obvious major difference is the syntax, secondly it introduces quite a bunch of duplicated code. If the current hostusb hook is a bit modified, it can handle both scenarios pretty well from my opinion.

-- 
To view, visit http://gerrit.ovirt.org/17428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list