Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Jul 30 14:07:09 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/vm.py
Line 379:                 # we may return migration stop but it will start at libvirt
Line 380:                 # side
Line 381:                 self._preparingMigrationEvt = False
Line 382:                 if not self._migrationCanceledEvt:
Line 383:                     # Note on VIR_MIGRATE_ABORT_ON_ERROR:
i don't think this is needed....
Line 384:                     #
Line 385:                     # The flag is added in libvirt-1.1.0, is available
Line 386:                     # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387:                     # be backported to RHEL 6.4 ever.


-- 
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list