Change in vdsm[master]: Support for multiple heads for Qxl display device

danken at redhat.com danken at redhat.com
Tue Jul 30 07:22:00 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Support for multiple heads for Qxl display device
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 1205:         """
Line 1206:         video = self.createXmlElem('video', None, ['address'])
Line 1207:         video.appendChildWithArgs('model', type=self.device,
Line 1208:                                   vram=self.specParams['vram'],
Line 1209:                                   heads=self.specParams['heads'])
"heads" is optional. If an old Engine does not send it, it has to default to 1.
Line 1210: 
Line 1211:         return video
Line 1212: 
Line 1213: 


-- 
To view, visit http://gerrit.ovirt.org/17067
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0799193df70edf7e0be2c172636df229c59d6aac
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list