Change in vdsm[master]: Improved ip rule and route robustness + improved logging

danken at redhat.com danken at redhat.com
Tue Jul 30 07:11:28 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Improved ip rule and route robustness + improved logging
......................................................................


Improved ip rule and route robustness + improved logging

* SuperVDSM should no longer crash when failing to parse routing
  rules.
* Improved logging - Routes / rules that cannot be parsed are
  logged.
* (Improved logging)^2 - Failing to configure or remove source
  routing no longer displays a scary stack trace, just the error
  message.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987335
Change-Id: If2240d7ec7dc3613c4cd8b6fa3b0bd3f55edefda
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17425
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M vdsm/sourceRoute.py
2 files changed, 36 insertions(+), 26 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/17425
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2240d7ec7dc3613c4cd8b6fa3b0bd3f55edefda
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list