Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Jul 29 13:31:09 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File lib/vdsm/config.py.in
Line 84:             'Incremental steps used to reach migration_downtime.'),
Line 85: 
Line 86:         ('migration_abort_on_eio', 'true',
Line 87:             'Abort VM migration on I/O error and refuse to migrate '
Line 88:             'VMs, paused because of EIO.'),
something like "Abort VM migration on I/O error (paused due to EIO)" ?
Line 89: 
Line 90:         ('max_outgoing_migrations', '3',
Line 91:             'Maximum concurrent outgoing migrations'),
Line 92: 


....................................................
File vdsm/vm.py
Line 385:                     # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 386:                     # be backported to RHEL 6.4 ever.
Line 387:                     # So the solution could be a dependency in the spec-file,
Line 388:                     # but this getattr() trick just let us not to do unneeded
Line 389:                     # fork.
why is this needed? starting _now_ it should work. F19 supports it and RHEL 6.5 as well
Line 390:                     self._vm._dom.migrateToURI2(
Line 391:                         duri, muri, None,
Line 392:                         libvirt.VIR_MIGRATE_LIVE |
Line 393:                         libvirt.VIR_MIGRATE_PEER2PEER |


-- 
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list