Change in vdsm[master]: More precise exception when multipath failed.

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Jul 28 21:00:04 UTC 2013


Eduardo has posted comments on this change.

Change subject: More precise exception when multipath failed.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/devicemapper.py
Line 34:     devlinkPath = DMPATH_FORMAT % deviceMultipathName
Line 35:     try:
Line 36:         devStat = os.stat(devlinkPath)
Line 37:     except OSError as e:
Line 38:         raise OSError(e.errno, "%s: %s: %s" %
Because the ENODEV is not especially honored anywhere, all the errors are the same.

Catching and re-raising to add deviceMultipathName (input) to the error string which includes only (claculated) devLinkPath.
Line 39:                       (deviceMultipathName, e.strerror, e.filename))
Line 40:     else:
Line 41:         return "dm-%d" % os.minor(devStat.st_rdev)
Line 42: 


-- 
To view, visit http://gerrit.ovirt.org/17145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b87e8e91b838db2c8a98c9afbbc998e8f4c792a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list