Change in vdsm[master]: Make getRepoStats() a hsm method.

abaron at redhat.com abaron at redhat.com
Sun Jul 28 20:35:59 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Make getRepoStats() a hsm method.
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2474:             se.StoragePoolActionError("spUUID=%s" % spUUID))
Line 2475:         vars.task.getSharedLock(STORAGE, spUUID)
Line 2476:         pool = self.getPool(spUUID)
Line 2477:         poolInfo = pool.getInfo()
Line 2478:         doms = pool.getDomains()
so call it with domainListDecoder... ?
Line 2479:         domInfo = self._getDomsStats(pool.domainMonitor, doms)
Line 2480:         for sdUUID in doms.iterkeys():
Line 2481:             if 'isoprefix' in domInfo[sdUUID] and domInfo[sdUUID]['isoprefix']:
Line 2482:                     poolInfo['isoprefix'] = domInfo[sdUUID]['isoprefix']


-- 
To view, visit http://gerrit.ovirt.org/14673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list