Change in vdsm[master]: Use strings when reporting VM's memory stats

danken at redhat.com danken at redhat.com
Fri Jul 26 07:56:05 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Use strings when reporting VM's memory stats
......................................................................


Patch Set 9: I would prefer that you didn't submit this

We have to rush this to ovirt-3.3, before anything is using these new balloonInfo.

However, why not do this simpler, by changing the implementation of _getBalloonInfo()? This generic convertToString() function is considered evil by many. I, too, prefer the precision of explicit conversion of the offending fields.

-- 
To view, visit http://gerrit.ovirt.org/17086
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b52fface17e5023c666ebed24dd5fc6b204dbc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list