Change in vdsm[master]: sos: collect permissions of /etc/vdsm/

kroberts at redhat.com kroberts at redhat.com
Wed Jul 24 14:59:39 UTC 2013


Keith Robertson has posted comments on this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

'ls' or 'stat' makes no difference to me.  Just throwing it out there.

....................................................
File vdsm/sos/vdsm.py.in
Line 80:             pid = line.strip()
Line 81:             self.addCopySpec("/proc/%s/cmdline" % pid)
Line 82:             self.addCopySpec("/proc/%s/status" % pid)
Line 83:             self.addCopySpec("/proc/%s/mountstats" % pid)
Line 84:         self.collectExtOutput("/bin/ls -lR /etc/vdsm")
This is fine.  However, the 'stat' command might be more useful.  Check this out...


stat /etc/libvirt/
  File: `/etc/libvirt/'
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: fd00h/64768d	Inode: 545643      Links: 2
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2013-07-17 16:12:10.326039581 -0400
Modify: 2013-07-17 21:07:03.328316933 -0400
Change: 2013-07-17 21:07:03.328316933 -0400
Line 85:         self.collectExtOutput("/bin/ls -l /var/log/core")
Line 86:         self.collectExtOutput(
Line 87:             "/bin/su vdsm -s /bin/sh -c '/usr/bin/tree -l @VDSMREPO@'")
Line 88:         self.collectExtOutput(


-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: humble devassy <hchiramm at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list