Change in vdsm[master]: Make lvm.listPVNames() be based on vgs information.

abaron at redhat.com abaron at redhat.com
Wed Jul 24 11:32:48 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Make lvm.listPVNames() be based on vgs information.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/lvm.py
Line 393:             for line in out:
Line 394:                 fields = [field.strip() for field in line.split(SEPARATOR)]
Line 395:                 uuid = fields[VG._fields.index("uuid")]
Line 396:                 pvNameIdx = VG._fields.index("pv_name")
Line 397:                 pv_name = fields[pvNameIdx]
why is this pv_name and not pv_names ?
Line 398:                 if uuid not in vgsFields:
Line 399:                     fields[pvNameIdx] = [pv_name]  # Make a pv_names list
Line 400:                     vgsFields[uuid] = fields
Line 401:                 else:


-- 
To view, visit http://gerrit.ovirt.org/14631
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e04a73476cab53e9a0a6c74eab2e747380f25c4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list