Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...

sgotliv at redhat.com sgotliv at redhat.com
Wed Jul 24 05:59:18 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/iscsi.py
Line 182: 
Line 183:     with _iscsiadmTransactionLock:
Line 184:         iscsiadm.discoverydb_new(discoverType, iface.name, portalStr)
Line 185: 
Line 186:         try:
Its not related to the patch. This patch resolves a bug, please, see bug-url. All other changes even if they are make our code better are irrelevant for that issue.
Line 187:             # Push credentials
Line 188:             if credentials is not None:
Line 189:                 for key, value in credentials.getIscsiadmOptions():
Line 190:                     key = "discovery.sendtargets." + key


-- 
To view, visit http://gerrit.ovirt.org/17212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list