Change in vdsm[master]: fix setupNets 'remove' of non-existent net

amuller at redhat.com amuller at redhat.com
Tue Jul 23 14:34:45 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: fix setupNets 'remove' of non-existent net
......................................................................


Patch Set 1:

Yeah, I see that it's used in the same way in delNetwork. That doesn't mean that ERR_BAD_BRIDGE is in any way related to this type of error. I also see that it is used in netmodels:Bridge:validateName, where it makes more sense.

We should create a new error code and use it during delNetwork and setupNetworks.

-- 
To view, visit http://gerrit.ovirt.org/17254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list