Change in vdsm[master]: Improve logging for misformed ip routes and rules

danken at redhat.com danken at redhat.com
Tue Jul 23 09:34:48 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Improve logging for misformed ip routes and rules
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File lib/vdsm/ipwrapper.py
Line 60:         The network / first column is required, followed by key+value pairs.
Line 61:         Thus, the length of a route must be odd.
Line 62:         """
Line 63:         if len(route) % 2 == 0:
Line 64:             raise ValueError('Route: %s. The length of the textual '
Minor typo: colon should sit to the right of %s.
Line 65:                              'representation of a route must be odd.' % route)
Line 66: 
Line 67:         network, params = route[0], route[1:]
Line 68:         data = dict(params[i:i + 2] for i in range(0, len(params), 2))


-- 
To view, visit http://gerrit.ovirt.org/17239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list