Change in vdsm[master]: PARTIAL: explicitly close libvirt connection after use

asegurap at redhat.com asegurap at redhat.com
Mon Jul 22 17:39:09 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: PARTIAL: explicitly close libvirt connection after use
......................................................................


Patch Set 1:

The difference is that using "new" allows you not to change the old usage, i.e., you still return a conn object on which you can execute queries. However, if you use it with "with" it will behave like a context manager.

As for the refcounting, I agree, we should probably do better connection management.

-- 
To view, visit http://gerrit.ovirt.org/17192
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15f3ab017828a63960ba9311fa2bf6bfab4729
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list