Change in vdsm[master]: vdsm: fileSD.py has a reference to the removed safeUnlink
ewarszaw at redhat.com
ewarszaw at redhat.com
Sun Jul 21 15:52:27 UTC 2013
Eduardo has posted comments on this change.
Change subject: vdsm: fileSD.py has a reference to the removed safeUnlink
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Good catch!
The conflict was caused by cherry-picking I8d6531bd on top of Idce0f3f1.
....................................................
Commit Message
Line 6:
Line 7: vdsm: fileSD.py has a reference to the removed safeUnlink
Line 8:
Line 9: the method safeUnlink was replaced by rmFile
Line 10: changed the file to use the new method
Please change this comment accordingly with the comment in fileSD.py
Line 11:
Line 12: Change-Id: I5e6d632d6b1dcdbffa48158065921b3313a0b96a
....................................................
File vdsm/storage/fileSD.py
Line 555: # namespaces are locked.
Line 556: for volFile in volFiles:
Line 557: tLink = os.path.join(basePath, rImg, volFile)
Line 558: tVol = os.path.join(basePath, templateImage, volFile)
Line 559: self.oop.utils.rmFile(tLink)
Please replace the rmFile and os.link calls by:
self.oop.os.forceLink(tVol, tLink)
Line 560: self.oop.os.link(tVol, tLink)
Line 561:
Line 562:
Line 563: def getMountsList(pattern="*"):
--
To view, visit http://gerrit.ovirt.org/17173
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6d632d6b1dcdbffa48158065921b3313a0b96a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list