Change in vdsm[master]: Add iproute2 configurator
psebek at redhat.com
psebek at redhat.com
Thu Jul 18 10:55:30 UTC 2013
Petr Šebek has posted comments on this change.
Change subject: Add iproute2 configurator
......................................................................
Patch Set 4: (1 inline comment)
Waiting to see what will happen with that vlan issue.
....................................................
File vdsm/netconf/iproute2.py
Line 103: ipwrapper.linkDel(['dev', vlan.name])
Line 104: vlan.device.remove()
Line 105:
Line 106: def _ifaceDownAndCleanup(self, iface, _netinfo):
Line 107: """Returns True iff the iface is to be removed."""
minor typo? iff -> if
Line 108: self.configApplier.ifdown(iface)
Line 109: if iface.master is None:
Line 110: self.configApplier.removeIpConfig(iface)
Line 111: return not _netinfo.ifaceUsers(iface.name)
--
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Šebek <psebek at redhat.com>
More information about the vdsm-patches
mailing list