Change in vdsm[master]: vdsm: Adding guest agent API versioning support
msivak at redhat.com
msivak at redhat.com
Thu Jul 18 09:45:41 UTC 2013
Martin Sivák has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks good, but please document the behaviour at least a tiny bit.
....................................................
File vdsm/guestIF.py
Line 98: MAX_MESSAGE_SIZE = 2 ** 20 # 1 MiB for now
Line 99:
Line 100: def __init__(self, socketName, channelListener, log, user='Unknown',
Line 101: ips='', connect=True):
Line 102: self.apiVersion = 0
Can you please describe the function and logic of this attribute here?
I would like to see at least the information that it is negotiated with the guest agent and ends up the common lowest version that both vdsm and guest-agent support.
Line 103: self.log = log
Line 104: self._socketName = socketName
Line 105: self._stopped = True
Line 106: self.guestStatus = None
--
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9095b528c2c910f12d5f170088a458bf11c71910
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list