Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed Jul 17 02:44:41 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/sampling.py
Line 160:         for p in self.MONITORED_PATHS:
Line 161:             rc, out, _ = utils.execCmd(['stat', '--file-system', '--format=%T',
Line 162:                                         p])
Line 163:             if rc == 0 and out[0] == 'tmpfs':
Line 164:                 continue
Good point! But in current Host sampling code,  it has the same effect of putting it into __init__ and _getDiskStats, because it create a new instance of HostSample in every sampling. You approach will show its advantadge after we refactor the host sampling code.
Line 165: 
Line 166:             free = 0
Line 167:             try:
Line 168:                 stat = os.statvfs(p)


-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list