Change in vdsm[master]: image: add support to upload/download images

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Tue Jul 16 13:51:13 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: image: add support to upload/download images
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 1162: 
Line 1163:         if template or len(chain) > 1:
Line 1164:             self.log.error("Importing and exporting an image with more "
Line 1165:                            "than one volume is not supported")
Line 1166:             raise se.CopyImageError()
Why can't we use qemu-img convert to convert the chain into a qcow2/raw image and then use it for upload/download ?
Line 1167: 
Line 1168:         domain.activateVolumes(imgUUID, volUUIDs=[chain[0].volUUID])
Line 1169:         return chain[0]
Line 1170: 


-- 
To view, visit http://gerrit.ovirt.org/14955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib208bb20d88633167b5c66b42febe912439a022d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list