Change in vdsm[master]: vdsmd.init.in: extract common init tasks
zhshzhou at linux.vnet.ibm.com
zhshzhou at linux.vnet.ibm.com
Tue Jul 16 09:41:52 UTC 2013
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: extract common init tasks
......................................................................
Patch Set 10: No score; I would prefer that you didn't submit this
(2 inline comments)
This patch is squashed to http://gerrit.ovirt.org/#/c/15578/ "vdsmd.init.in: extract common init tasks and add init adapter" . After 15578 is done, this patch will be abandoned. Now leave it be as reference, mark -1 to filter itself out for other reviewers .
....................................................
File vdsm/vdsmd_init_common.sh.in
Line 241: tasks="run_init_hooks gencerts libvirt_reconfigure \
Line 242: syslog_available nwfilter dummybr load_needed_modules \
Line 243: tune_system mkdirs test_space test_lo \
Line 244: test_conflicting_conf"
Line 245: run_tasks "$tasks"
Done
Line 246: ;;
Line 247: --post-stop)
Line 248: tasks="run_final_hooks"
Line 249: run_tasks "$tasks"
Line 253: start_needed_srv "$@"
Line 254: ;;
Line 255: --shutdown-conflicting-srv)
Line 256: shift
Line 257: shutdown_conflicting_srv "$@"
Good idea. I still thinks keeping the two functions in this file is simpler and does not break portability of this file. I think this file is for managing all the trivial init staffs.
Line 258: ;;
Line 259: --)
Line 260: usage
Line 261: exit 1
--
To view, visit http://gerrit.ovirt.org/14826
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c652704000c764c6e6f248605c6a3f4f3af5ace
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list